Sema: Don't talk about @_versioned in diagnostics for default arguments [4.0] #10348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes <rdar://problem/32445206> and <https://bugs.swift.org/browse/SR-4648>.
|
@swift-ci Please test |
|
@jrose-apple Can you take a look please? |
jrose-apple
approved these changes
Jun 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Just a cosmetic fix, don't talk about @_versioned in diagnostics pertaining to default arguments.
Origination: Swift 3.1 added resilience diagnostics for inlineable code, which is not an officially supported feature, but in Swift 4 we switched these checks on for default argument expressions as well, so they should not talk about internal attributes.
Risk: None, hopefully.
Tested: Test updated for new diagnostic strings.
Reviewed by: @jrose-apple
Radar: Fixes rdar://problem/32445206.